Adding check on cd status#969
Closed
visheshtanksale wants to merge 1 commit intokubernetes-sigs:mainfrom
Closed
Conversation
Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
jgehrcke
reviewed
Mar 30, 2026
| cd.Status.Status = m.calculateGlobalStatus(cd) | ||
|
|
||
| // Validate status invariants: crash loudly if a node index is used more than once. | ||
| validateCDStatusNodes(cd) |
Contributor
There was a problem hiding this comment.
I don't think we should do this in the controller.
The original ticket that I believe you are taking reference to was more about an assert-style invariant check in the direct write/update code path.
This may actually be implied as of today, the code evolved a bit.
Contributor
Author
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
|
k8s-ci-robot
added
the
cncf-cla: no
Member
|
if we still want to do this, we'll need the CNCF CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #544